<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103777/">http://git.reviewboard.kde.org/r/103777/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3032a8b2d6bbf4703acb37bc5a53eeb417f35805 by Thibaut Gridel to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 23rd, 2012, 5:38 p.m., Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2012, 5:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch uses qreal for label collision detection, as screenCoordinates provides this precision.
This removes a lot of flicker due to truncating qreal to int.
Also provided (only for testing) is an indicator of the number of "available", "inside the viewport", "missed" labels due to roomForLabel in order to understand the reasons for flicker.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removes already some nasty flickering in dense zones where truncating qreal is the main cause for flicker.
Next is deciding some more:
- changing orders of magnitude for placemarks (levelling off some dense zones),
- increasing the number of available placemarks (which has a big impact also on flickering in some regions)
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=288297">288297</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/PlacemarkPainter.cpp <span style="color: grey">(509e5ed)</span></li>
<li>src/lib/VisiblePlacemark.h <span style="color: grey">(3382ee4)</span></li>
<li>src/lib/VisiblePlacemark.cpp <span style="color: grey">(9b88832)</span></li>
<li>src/lib/layers/PlacemarkLayout.h <span style="color: grey">(b020dd1)</span></li>
<li>src/lib/layers/PlacemarkLayout.cpp <span style="color: grey">(7f66464)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103777/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>