<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103711/">http://git.reviewboard.kde.org/r/103711/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4957d88eba144f775493d2b95db1788070cfe53a by Bernhard Beschow to branch KDE/4.8.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 17th, 2012, 12:21 a.m., Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2012, 12:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instantiating a QEventLoop is now subject to the runners. Only runners which use asynchronous API (networking) make use of QEventLoops, while the others perform their work in the respective methods (which are run in a thread).
In addition, the runners are now instantiated in the background thread rather than in the GUI thread, which avoids thread affinity issues. In particular, it seems to avoid QEventLoops to be assigned to the GUI thread, causing them to block forever in the background threads.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">online + offline routes, addresses, and online + offline placemarks were found and displayed successfully on the following platforms:
* x86 desktop with Qt 4.8.0
* Maemo 5 (N900) with Qt 4.7.0
* desktop Windows (wine) with Qt 4.7.4</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=288612">288612</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleRunnerManager.h <span style="color: grey">(18c0864)</span></li>
<li>src/lib/MarbleRunnerManager.cpp <span style="color: grey">(9b04537)</span></li>
<li>src/lib/RunnerTask.h <span style="color: grey">(6b4f7aa)</span></li>
<li>src/lib/RunnerTask.cpp <span style="color: grey">(fb4d1a5)</span></li>
<li>src/plugins/runner/hostip/HostipRunner.h <span style="color: grey">(b4bdd37)</span></li>
<li>src/plugins/runner/hostip/HostipRunner.cpp <span style="color: grey">(f079f5d)</span></li>
<li>src/plugins/runner/nominatim/OsmNominatimRunner.cpp <span style="color: grey">(f55975c)</span></li>
<li>src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp <span style="color: grey">(015381d)</span></li>
<li>src/plugins/runner/yours/YoursRunner.cpp <span style="color: grey">(a86a34e)</span></li>
<li>tests/MarbleRunnerManagerTest.cpp <span style="color: grey">(3f2fb10)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103711/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>