<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103591/">http://git.reviewboard.kde.org/r/103591/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, works fine. I'm wondering whether there is a more intuitive naming distinction between findPlacemarks() and searchPlacemarks() that makes it more clear that one is the blocking and one is the async one (same for the other ones).</pre>
<br />
<p>- Dennis</p>
<br />
<p>On December 30th, 2011, 11:57 p.m., Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2011, 11:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> - xxFinished signals are emitted when all runners are finished
- new blocking methods that wait for all runners to return the results
- fixes for runners which didn't signal their end properly</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">simple test cases for each runner, in sync and async mode.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleRunnerManager.h <span style="color: grey">(7ba1c6c)</span></li>
<li>src/lib/MarbleRunnerManager.cpp <span style="color: grey">(26e7d56)</span></li>
<li>src/lib/RunnerTask.cpp <span style="color: grey">(fb4d1a5)</span></li>
<li>src/plugins/runner/cache/CacheRunner.cpp <span style="color: grey">(76b6c3f)</span></li>
<li>src/plugins/runner/gpx/GpxRunner.cpp <span style="color: grey">(6ff1390)</span></li>
<li>src/plugins/runner/kml/KmlRunner.cpp <span style="color: grey">(70b6014)</span></li>
<li>src/plugins/runner/osm/OsmRunner.cpp <span style="color: grey">(0967871)</span></li>
<li>src/plugins/runner/pnt/PntRunner.cpp <span style="color: grey">(c1026c3)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(8fe8be5)</span></li>
<li>tests/MarbleRunnerManagerTest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103591/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>