<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103167/">http://git.reviewboard.kde.org/r/103167/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit af5e5121a69a7d30d1718b44f47335c5fd25b637 by Thibaut Gridel to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 17th, 2011, 3:24 p.m., Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Thibaut Gridel.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Nov. 17, 2011, 3:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">GeometryLayer and PlacemarkLayout are currently wired up in MarbleMap. Since MarbleMap is basically a container for layers, it shouldn't have to know about implementation details of any specific layer. Therefore, the connect() statements should move into the respective layers themselves.
Before the connections can be wired up in the layers, a change to GeoDataTreeModel should be made: The treeChanged() signal seems redundant to QAbstractItemModel::layoutChanged(), and is currently only used for updating GeometryLayer and PlacemarkLayout. Therefore, GeoDataTreeModel can emit layoutChanged() such that treeChanged() can be removed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works for me. I'm not sure whether all changes of the models are correctly caught by the layers, esp. in the PlacemarkLayer. Please report any issues you see. Thx!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/GeoDataTreeModel.h <span style="color: grey">(fa919ba)</span></li>
<li>src/lib/GeoDataTreeModel.cpp <span style="color: grey">(3056153)</span></li>
<li>src/lib/MarbleMap.cpp <span style="color: grey">(3eb5a76)</span></li>
<li>src/lib/layers/GeometryLayer.cpp <span style="color: grey">(53b5c32)</span></li>
<li>src/lib/layers/PlacemarkLayout.cpp <span style="color: grey">(6cf3943)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103167/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>