<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103407/">http://git.reviewboard.kde.org/r/103407/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Anders Lund.</div>
<p style="color: grey;"><i>Updated Dec. 18, 2011, 4:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes according to suggestions</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">More gpx improvements:
* Use desc tag to add waypoint and route descriptions
* Set a default Role for routepoints and waypoints, and use the gpx type tag to change that if present
* Support custom role by displaying a custom role string in placemark information dialog if present
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've been using this without problems, and verified that descriptions and roles display correctly
Tried this loading a vareity of different gpx files found on the net</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/CMakeLists.txt <span style="color: grey">(63b048b)</span></li>
<li>data/bitmaps/markers/accommodation_camping.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/accommodation_caravan_park.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/accommodation_hotel.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/accommodation_hotel2.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/amenity_court.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/amenity_library.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/amenity_police.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/amenity_post_office.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/amenity_telephone.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/amenity_toilets.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/amenity_town_hall.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/barrier_exit.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/barrier_lift_gate.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/barrier_toll_booth.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/education_school.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/food_bar.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/food_drinkingtap.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/food_fastfood.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/food_pizza.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/food_restaurant.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/generic_circle_with_x.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/generic_flag.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/generic_smiley.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/geocaching_geocache.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/health_hospital.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/health_pharmacy.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/landuse_coniferous_and_deciduous.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/landuse_quary.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/money_bank2.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/place_of_worship_christian.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/place_of_worship_christian3.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/poi_embassy.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/poi_mine.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/poi_mountain_pass.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/poi_peak2.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/poi_tower_communications.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/shopping_car.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/shopping_car_repair.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/shopping_convenience.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/shopping_department_store.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/shopping_supermarket.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/sport_fishing.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/sport_golf.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/sport_gym.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/sport_iceskating.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/sport_leisure_centre.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/sport_shooting.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/sport_skiing_crosscountry.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/sport_skiing_downhill.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/sport_stadium.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/sport_swimming_outdoor.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_attraction.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_beach.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_casino.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_cinema.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_information.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_museum.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_picnic.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_scenic_area.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_theatre.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_theme_park.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_view_point.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_wreck.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/tourist_zoo.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/transport_airport.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/transport_fuel.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/transport_helicopter.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/transport_marina.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/transport_parking.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/transport_rental_car.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/transport_slipway.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/markers/water_dam.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/PlacemarkInfoDialog.cpp <span style="color: grey">(e9889ee)</span></li>
<li>src/plugins/runner/gpx/CMakeLists.txt <span style="color: grey">(e0d3e07)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXElementDictionary.h <span style="color: grey">(c5c35f7)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXElementDictionary.cpp <span style="color: grey">(8355a3b)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXcmtTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXdescTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXdescTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp <span style="color: grey">(14ea21f)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXnameTagHandler.h <span style="color: grey">(5ff3dca)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXnameTagHandler.cpp <span style="color: grey">(400c9c8)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXrteTagHandler.cpp <span style="color: grey">(022744d)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXrteptTagHandler.h <span style="color: grey">(c5b420a)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXrteptTagHandler.cpp <span style="color: grey">(994fcbf)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXsymTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXsymTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXtypeTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXwptTagHandler.cpp <span style="color: grey">(b7efbe4)</span></li>
<li>src/plugins/runner/gpx/handlers/GpxSymbols.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GpxSymbols.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>your-patch.patch <span style="color: grey">(96675b8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103407/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>