<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103314/">http://git.reviewboard.kde.org/r/103314/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess this one could get committed even now that we are in string freeze?</pre>
<br />
<p>- Torsten</p>
<br />
<p>On December 3rd, 2011, 2:29 p.m., Florian Eßer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Florian Eßer.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2011, 2:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Based on the discussion from https://git.reviewboard.kde.org/r/102540/ this patch turns the hardcoded colors in the routing layer into softcoded colors and alpha values that are stored in the config files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done for both KDE and Qt-only:
* compile
* start and close Marble --> default values are written to config file (Qt)
* manually edit the config files (~/.kde/share/config/marblerc and ~/.config/kde.org/Marble Desktop Globe.conf) and add/change the colors and alpha values there
* start Marble again --> route is rendered in different color
I could only test the default route color. I guess the other two are used while GPS navigating?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/QtMainWindow.cpp <span style="color: grey">(1c24071)</span></li>
<li>src/lib/routing/RoutingLayer.cpp <span style="color: grey">(a5454ee)</span></li>
<li>src/lib/routing/RoutingManager.h <span style="color: grey">(dad9357)</span></li>
<li>src/lib/routing/RoutingManager.cpp <span style="color: grey">(8488a56)</span></li>
<li>src/marble.kcfg <span style="color: grey">(5f5dfa2)</span></li>
<li>src/marble_part.cpp <span style="color: grey">(1bad437)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103314/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>