<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103288/">http://git.reviewboard.kde.org/r/103288/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks OK, I didn't test it though.
Please commit.</pre>
<br />
<p>- Thibaut</p>
<br />
<p>On November 29th, 2011, 12:29 a.m., Javier Becerra Elcinto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Javier Becerra Elcinto.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2011, 12:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add support for writing TimeStamp tag to kml file.
This patch includes files KmlTimeStampTagWriter.cpp and KmlTimeStampTagWriter.h, and the modifications required in KmlDocumentTagWriter.cpp, KmlFolderTagWriter.cpp and KmlPlacemarkTagWriter.cpp to write to file valid TimeStamp information.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Succesfully tested writing TimeStamp tags to a kml file using GeoWriter.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/geodata/writers/kml/KmlDocumentTagWriter.cpp <span style="color: grey">(aa80f62)</span></li>
<li>src/lib/geodata/writers/kml/KmlFolderTagWriter.cpp <span style="color: grey">(5e77dc1)</span></li>
<li>src/lib/geodata/writers/kml/KmlPlacemarkTagWriter.cpp <span style="color: grey">(1a19c17)</span></li>
<li>src/lib/geodata/writers/kml/KmlTimeStampTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/writers/kml/KmlTimeStampTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103288/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>