<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103295/">http://git.reviewboard.kde.org/r/103295/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 30th, 2011, 12:16 p.m., <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there a reason why some methods are called "measureSystem" instead of "measurementSystem"? Would be more consistent. Apart from that the patch looks fine to me.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The reasons are history: Marble called its enum MeasureSystem, while Qt calles it MeasurementSystem. The same applies for the methods. I'll adopt the names to the Qt way in a separate commit.</pre>
<br />
<p>- Bernhard</p>
<br />
<p>On November 30th, 2011, 11:53 a.m., Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Nov. 30, 2011, 11:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Having both distanceUnit() and measureSystem() in the API creates ambiguities for programmers. In addition, distanceUnit() and measureSystem() could refer to different measure systems, leading to inconsistencies in Marble. It makes therefore sense to unify DistanceUnit and the measure system.
This patch replaces all usages of DistanceUnit by QLocale::MeasurementSystem and removes the respective methods from MarbleLocale.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/QtMainWindow.cpp <span style="color: grey">(011f080)</span></li>
<li>src/lib/MarbleLocale.h <span style="color: grey">(cb55542)</span></li>
<li>src/lib/MarbleLocale.cpp <span style="color: grey">(a970dd3)</span></li>
<li>src/lib/MarbleLocale_p.h <span style="color: grey">(9702970)</span></li>
<li>src/lib/MarbleWidget.cpp <span style="color: grey">(717791c)</span></li>
<li>src/lib/QtMarbleConfigDialog.h <span style="color: grey">(04ebee6)</span></li>
<li>src/lib/QtMarbleConfigDialog.cpp <span style="color: grey">(6ae77f5)</span></li>
<li>src/lib/TinyWebBrowser.cpp <span style="color: grey">(f0a2a66)</span></li>
<li>src/lib/global.h <span style="color: grey">(778c991)</span></li>
<li>src/lib/layers/MeasureTool.cpp <span style="color: grey">(56691f0)</span></li>
<li>src/marble.kcfg <span style="color: grey">(06277c8)</span></li>
<li>src/marble_part.cpp <span style="color: grey">(b77aeef)</span></li>
<li>src/plugins/render/elevationprofile/ElevationProfileFloatItem.cpp <span style="color: grey">(af5b5b7)</span></li>
<li>src/plugins/render/gpsinfo/GpsInfo.cpp <span style="color: grey">(f0a7eb8)</span></li>
<li>src/plugins/render/mapscale/MapScaleFloatItem.cpp <span style="color: grey">(ba05324)</span></li>
<li>src/plugins/render/routing/RoutingPlugin.cpp <span style="color: grey">(40ec8d8)</span></li>
<li>src/plugins/render/speedometer/Speedometer.cpp <span style="color: grey">(d0accaa)</span></li>
<li>src/plugins/runner/local-osm-search/OsmDatabase.cpp <span style="color: grey">(d2c976c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103295/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>