<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103053/">http://git.reviewboard.kde.org/r/103053/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I meant that the disambiguation menu (lmb menu) is always shown when clicked, even if there is only one entry.</pre>
<br />
<p>- Bernhard</p>
<br />
<p>On November 15th, 2011, 2:40 p.m., Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2011, 2:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The lmb as well as the rmb menu offer actions regarding the current geo position. In particular, the lmb menu offers "Copy Coordinates" and "Address Details", while the rmb menu offers "Add Bookmark" and "Set Home Location". As a result, neither of the menus have precise duties, creating ambiguities, which this patch addresses. Moreover, this patch also addresses bug 282394.
The changes in the patch include:
* concentrate all actions regarding the current geo position in the rmb menu
* remove unimplemented planet action
* use the lmb menu only for resolving ambiguities when opening links
The lmb menu only appears when there are ambiguities. Otherwise, the internal browser is opened immediately or the lmb menu is ignored when there are no actions available.
The rmb menu got a new sub menu which includes the four actions from above. See screenshot for details.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The menus make more sense.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=282394">282394</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleWidgetPopupMenu.h <span style="color: grey">(c31f14e)</span></li>
<li>src/lib/MarbleWidgetPopupMenu.cpp <span style="color: grey">(d3607de)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103053/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103053/s/324/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/06/lmb-menu_400x100.png" style="border: 1px black solid;" alt="LMB menu resolving ambiguities" /></a>
<a href="http://git.reviewboard.kde.org/r/103053/s/325/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/06/rmb-menu_400x100.png" style="border: 1px black solid;" alt="new RMB menu" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>