<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103081/">http://git.reviewboard.kde.org/r/103081/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 8th, 2011, 7:43 p.m., <b>Niko Sams</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103081/diff/1/?file=40679#file40679line163" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/geodata/data/GeoDataTrack.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void GeoDataTrack::appendWhen( const QDateTime &when )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">163</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">m_pointMap</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span> <span class="n">when</span><span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">m_coordStack</span><span class="p">.</span><span class="n">takeLast</span><span class="p">()</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this inserts the corrdinates in reverse order; it should be takeFirst()
(same with appendCoordinates)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for that! Please push your unit test to master! :)</pre>
<br />
<p>- Guillaume</p>
<br />
<p>On November 8th, 2011, 5:12 p.m., Guillaume Martres wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Thibaut Gridel.</div>
<div>By Guillaume Martres.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2011, 5:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is used in the Satellites plugin and could be used for routing and elsewhere.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/QtMainWindow.cpp <span style="color: grey">(851472c)</span></li>
<li>src/lib/FileLoader.cpp <span style="color: grey">(ebda20b)</span></li>
<li>src/lib/MarbleClock.h <span style="color: grey">(e8d9217)</span></li>
<li>src/lib/MarbleMap.cpp <span style="color: grey">(06bc20d)</span></li>
<li>src/lib/MarbleWidget.cpp <span style="color: grey">(0719e8b)</span></li>
<li>src/lib/MarbleWidgetPopupMenu.cpp <span style="color: grey">(762c406)</span></li>
<li>src/lib/PlacemarkInfoDialog.h <span style="color: grey">(e9f8f47)</span></li>
<li>src/lib/PlacemarkInfoDialog.cpp <span style="color: grey">(d551d2f)</span></li>
<li>src/lib/geodata/data/GeoDataLineString.cpp <span style="color: grey">(79b0180)</span></li>
<li>src/lib/geodata/data/GeoDataPlacemark.h <span style="color: grey">(46842d7)</span></li>
<li>src/lib/geodata/data/GeoDataPlacemark.cpp <span style="color: grey">(14634ed)</span></li>
<li>src/lib/geodata/data/GeoDataTrack.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/data/GeoDataTrack.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/data/Serializable.h <span style="color: grey">(db1e5ad)</span></li>
<li>src/lib/geodata/graphicsitem/GeoTrackGraphicsItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/graphicsitem/GeoTrackGraphicsItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/handlers/kml/KmlAltitudeModeTagHandler.cpp <span style="color: grey">(a57a694)</span></li>
<li>src/lib/geodata/handlers/kml/KmlCoordinatesTagHandler.cpp <span style="color: grey">(a62d757)</span></li>
<li>src/lib/geodata/handlers/kml/KmlElementDictionary.h <span style="color: grey">(0efb3d7)</span></li>
<li>src/lib/geodata/handlers/kml/KmlElementDictionary.cpp <span style="color: grey">(7081526)</span></li>
<li>src/lib/geodata/handlers/kml/KmlTrackTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/handlers/kml/KmlTrackTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/handlers/kml/KmlWhenTagHandler.cpp <span style="color: grey">(7f0f0ae)</span></li>
<li>src/lib/geodata/parser/GeoDataParser.cpp <span style="color: grey">(bd3f71c)</span></li>
<li>src/lib/geodata/parser/GeoDataTypes.h <span style="color: grey">(cae1451)</span></li>
<li>src/lib/geodata/parser/GeoDataTypes.cpp <span style="color: grey">(e85dd4e)</span></li>
<li>src/lib/geodata/writer/GeoWriter.h <span style="color: grey">(953fedf)</span></li>
<li>src/lib/geodata/writer/GeoWriter.cpp <span style="color: grey">(ef64ecf)</span></li>
<li>src/lib/geodata/writers/kml/KmlTrackWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/writers/kml/KmlTrackWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/layers/GeometryLayer.cpp <span style="color: grey">(8eb86c8)</span></li>
<li>src/lib/layers/PlacemarkLayout.h <span style="color: grey">(082e8ee)</span></li>
<li>src/lib/layers/PlacemarkLayout.cpp <span style="color: grey">(cdea897)</span></li>
<li>src/plugins/positionprovider/placemark/PlacemarkPositionProviderPlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103081/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>