<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102849/">http://git.reviewboard.kde.org/r/102849/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code looks fine. Disclaimer: I haven't tested it though. </pre>
<br />
<p>- Torsten</p>
<br />
<p>On October 31st, 2011, 9:36 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2011, 9:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initial version of a Plasma Runner which uses Marble. So far can do:
* detect lonlat coordinates and start a new Marble instance showing that coordinates with OSM
* detect Marble bookmarks containing the search string in name or description (unless CDATA)
and start a new Marble instance showing that bookmark's coordinates with OSM
Support for Marble runners is not in the scope of this patch.
And parsing lonlat needs to be improved, still. WIP in another branch of mine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used a few times.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(b9b4a3b)</span></li>
<li>src/QtMainWindow.h <span style="color: grey">(8c3cfe3)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(e57feca)</span></li>
<li>src/kdemain.cpp <span style="color: grey">(eee55df)</span></li>
<li>src/plasmarunner/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/plasma-runner-marble.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/plasmarunner.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/plasmarunner.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qtmain.cpp <span style="color: grey">(3d6d1c7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102849/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>