<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102849/">http://git.reviewboard.kde.org/r/102849/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 15th, 2011, 8:58 p.m., <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102849/diff/2/?file=38890#file38890line340" style="color: black; font-weight: bold; text-decoration: underline;">src/kdemain.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int main ( int argc, char *argv[] )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">340</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">GeoDataCoordinates</span> <span class="n">coordinates</span> <span class="o">=</span> <span class="n">GeoDataCoordinates</span><span class="o">::</span><span class="n">fromString</span><span class="p">(</span><span class="n">coordinatesString</span><span class="p">,</span> <span class="n">success</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That probably made you feel even more motivated about fixing the fromString method, right? ;-)</pre>
</blockquote>
<p>On October 16th, 2011, 5:09 p.m., <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right. But that is work in another branch, will take some more days before being complete :)
And some of the lonlat variants are successfully parsed, so that should not block this merge request I think.
It already adds value and works for what used to work in Marble as well, when entering the lonlat coords in the Search field.
Even more works fine with the bookmarks. For me at least :)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No worries, I was just kidding. :-)</pre>
<br />
<p>- Torsten</p>
<br />
<p>On October 16th, 2011, 5:05 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2011, 5:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initial minimal version of my planned Plasma Runner. So far only detects lonlat coordinates and starts a new Marble showing that coordinates with OSM.
Support for Marble runners and bookmarks is to come. And parsing needs to be improved, still. WIP.
Are commandline arguments for Marble okay?
Discovers some rendering problems in Marble widget on start, someone might investigate that (no clue myself yet).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used a few times.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(a0e4e7a)</span></li>
<li>src/kdemain.cpp <span style="color: grey">(eee55df)</span></li>
<li>src/plasmarunner/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/plasma-runner-marble.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/plasmarunner.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/plasmarunner.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qtmain.cpp <span style="color: grey">(3d6d1c7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102849/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>