<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102875/">http://git.reviewboard.kde.org/r/102875/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">== Problem ==
When emitting repaintNeeded() inside a RenderPlugin, MarbleWidget used to delay repainting for every RenderPlugin by 1 second.
However, some RenderPlugins/LayerInterfaces (such as PlacemarkLayout) may require to be updated immediately, so forcing a delay for every plugin/layer may lead to undesired rendering artifacts.
== Solution ==
Moving the responsibility for repaint delaying into the plugins/layers works for inhomogeneous requirements.
== Changes ==
When MarbleWidget receives repaintNeeded() from any plugin/layer, it update()s immediately.
ProgressFloatItem and TextureLayer are currently the only plugins/layers that make use of repaint delaying.
== Question ==
* are there any other layers/plugins that need repaint delaying, such as Wikipedia?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Repaints are delayed when updated tiles arrive. This is also the case when the ProgressFloatItem is visible.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleWidget.h <span style="color: grey">(b81ba55)</span></li>
<li>src/lib/MarbleWidget.cpp <span style="color: grey">(c8249ac)</span></li>
<li>src/lib/RenderPlugin.h <span style="color: grey">(b2b8a2b)</span></li>
<li>src/lib/layers/TextureLayer.cpp <span style="color: grey">(8dfd405)</span></li>
<li>src/plugins/render/progress/ProgressFloatItem.h <span style="color: grey">(a86436c)</span></li>
<li>src/plugins/render/progress/ProgressFloatItem.cpp <span style="color: grey">(f0cade2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102875/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>