<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102831/">http://git.reviewboard.kde.org/r/102831/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 0235eefeef91dad472f34e3f8b98ad37257a5799 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 11th, 2011, 6:20 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Oct. 11, 2011, 6:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch extends LatLonEdit to optionally also show the coordinate in decimal notation.
As well as in a variant of DMS where secs are left out and instead mins are given in floating point notation.
I found this variant being used in a few places on the internet, also as option in Maemo Mapper ;)
Actually the data which got me into this Marble hacking were exactly in that format (from some GPS device).
So I think that should be supported as well. Problem is that the global enum AngleUnit ATM only has {DMSDegree, DecimalDegree, UTM}.
So it would need to be extended. What do you think? What is the proper term for that "DM" notation?
For support of UTM, I have not yet investigated, seems to be something more complex and not yet used throughout Marble, or?
The patch also changes the EditBookmarkDialog to set the lon and lat widgets to the notation of the map widget, if present.
But only, if present. And there is no widget present in case of the bookmarkseditor. Any idea how I could get </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Running Marble, switching the settings and creating bookmarks a few times.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/EditBookmarkDialog.cpp <span style="color: grey">(32382b4)</span></li>
<li>src/lib/LatLonEdit.h <span style="color: grey">(c81e380)</span></li>
<li>src/lib/LatLonEdit.cpp <span style="color: grey">(9af9cba)</span></li>
<li>src/lib/LatLonEdit.ui <span style="color: grey">(628a5f2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102831/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>