<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102637/">http://git.reviewboard.kde.org/r/102637/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Niko Sams.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2011, 4:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">update to altitude branch:
- added elevationprofile plugin (by Florian Eßer)
- remove altitude-profile plugin</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds an AltidudeModel that can be used to get the altitude/elevation of a coordinate. The altitude-profile plugin uses that to generate a profile for a route and calculate some statistics.
The altitude-profile will be replaced/merged with elevationprofile plugin that was developed in parallel.
The other important part are the tiles. I used the existing TileCreator, refactored it to be more flexible and made a binary that creates the needed png tiles from the nasa srtm files. This takes a loong time, just as the upload to files.kde.org that is still running.
Please review my changes especially also those to TileCreator.
To review this you can also use the altitude branch in the marble repository; that contains full history (which might be useful)
In the attached screenshot you can see the altitude-profile float widget (red line) and the elevationprofile float widget (black line) - not included in this request.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/CMakeLists.txt <span style="color: grey">(6f16a74)</span></li>
<li>data/maps/earth/srtm2/0/000000/000000_000000.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/maps/earth/srtm2/0/000000/000000_000001.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/maps/earth/srtm2/srtm2.dgml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/icons/elevationprofile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/AltitudeModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/AltitudeModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(328db8f)</span></li>
<li>src/lib/MarbleModel.h <span style="color: grey">(0e4f2c8)</span></li>
<li>src/lib/MarbleModel.cpp <span style="color: grey">(c1588f8)</span></li>
<li>src/lib/TileCreator.h <span style="color: grey">(5b58158)</span></li>
<li>src/lib/TileCreator.cpp <span style="color: grey">(0ffa155)</span></li>
<li>src/lib/routing/AlternativeRoutesModel.h <span style="color: grey">(945a745)</span></li>
<li>src/marble.qrc <span style="color: grey">(c92a412)</span></li>
<li>src/plugins/render/CMakeLists.txt <span style="color: grey">(37075b3)</span></li>
<li>src/plugins/render/elevationprofile/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofile/ElevationProfileConfigWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofile/ElevationProfileFloatItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofile/ElevationProfileFloatItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofile/elevationprofile.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofile/flag-red-mirrored.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/tilecreator-srtm2/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/tilecreator-srtm2/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/tilecreator-srtm2/tccore.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/tilecreator-srtm2/tccore.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102637/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102637/s/263/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/16/marble-altitude-profile_400x100.png" style="border: 1px black solid;" alt="altitude profile in action" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>