<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102608/">http://git.reviewboard.kde.org/r/102608/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 14th, 2011, 1:43 p.m., <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me.
Ideally the LatLonEdit would also take the Notation into account:
Check Marble's Settings dialog on the "View" tab: The Angle setting controls whether in Marble DMS or Decimal Notation is used: In Decimal Notation Marble uses a notation like 49,999° N 20,5° E while in DMS it uses 49° 59' 59" N 20° 30' 00" E. It would be great if the LatLonWidget would have a setNotation method and if inside Marble it would follow Marble settings. </pre>
</blockquote>
<p>On September 14th, 2011, 8:22 p.m., <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for review, pushed to master.
Missed to see that setting so far. Agreed, the bookmark editor should then offer a widget for Decimal editing if Angle is set to that.
Will give it a try to add such a mode to LatLonWidget.
BTW, would it make sense to you to rename LatLonWidget to LonLatWidget? Would follow the usual convention as mentioned in the CODING file that first comes the lon parameter, then the lan one. :)
And a more serious question: I just saw, of course after pushing, that it might not be a good idea to simply copy the old altitude to the new GeoDataCoordinates in EditBookmarkDialog::coordinates(), as that value may be pretty bogus.
Should that parameter perhaps be displayed as well in the bookmark editor, perhaps with an button next to it to "Get ground altitude for current lon and lat values" (button could have wizard icon or better on it).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding the Notation: great!
We have some inconsistency with the naming already due to the LatLon naming in the KML spec. So I'm not sure whether it's worth bothering to change existing occurances ... .
The altitude described refers to the altitude of the camera! So the coordinate is not the coordinate of the object but the coordinate of the observer above the object ... so it's not exactly bogus ... ;-)</pre>
<br />
<p>- Torsten</p>
<br />
<p>On September 13th, 2011, 11:09 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2011, 11:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patchs adds the possibility to see and also edit also the coords of a bookmark in the bookmark editor.
Initially used a lineeddit and GeoDataCoordinates::toString, but GeoDataCoordinates::fromString cannot yet handle coords with secs it seems.
So turned to use a LatLonEdit per coord.
Found LatLonEdit to be quite incomplete, so rewrote it to get it working for me.
E.g. LatLonEdit::setDimension(...) was pretty broken.
Also needed/wanted a double value for the secs editor, to enable more precision.
No idea if 2 digits is a sane number of digits after the ".".
If LatLonEdit has to stay ABI compatible I will have to redo it then, as I changed the API
(removed unused/useless dimensionChanged signal and changed some method signatures).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added and viewed/edited several coords of geo bookmarks, worked all fine, same values shown after reloading or same places focussed if selected.
Also tested overflow behaviour of LatLonEdit for quite some border cases.
LatLonEdit widget still works fine in worldclock plasmoid.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/BookmarkManagerDialog.cpp <span style="color: grey">(3f9db62)</span></li>
<li>src/lib/EditBookmarkDialog.h <span style="color: grey">(4157726)</span></li>
<li>src/lib/EditBookmarkDialog.cpp <span style="color: grey">(7e36ddc)</span></li>
<li>src/lib/EditBookmarkDialog.ui <span style="color: grey">(9baf50d)</span></li>
<li>src/lib/LatLonEdit.h <span style="color: grey">(4958805)</span></li>
<li>src/lib/LatLonEdit.cpp <span style="color: grey">(758a167)</span></li>
<li>src/lib/LatLonEdit.ui <span style="color: grey">(26774d3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102608/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>