<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102608/">http://git.reviewboard.kde.org/r/102608/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 14th, 2011, 10:10 p.m., <b>Thibaut Gridel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please close the review if it got pushed.
Even better doing it with REVIEW: ### in the commit message.</pre>
</blockquote>
<p>On September 14th, 2011, 10:17 p.m., <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure, was going to do in the end :)
Was just unsure if it still is possible to comment on it if it is closed, so kept it open for a while.
And this review was actually about a few commits, so unsure if it makes sense to just mark the last one with the REVIEW keyword.
Will test now if commenting still would be possible :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, okay, it possible, good, no reason then.</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On September 13th, 2011, 11:09 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2011, 11:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patchs adds the possibility to see and also edit also the coords of a bookmark in the bookmark editor.
Initially used a lineeddit and GeoDataCoordinates::toString, but GeoDataCoordinates::fromString cannot yet handle coords with secs it seems.
So turned to use a LatLonEdit per coord.
Found LatLonEdit to be quite incomplete, so rewrote it to get it working for me.
E.g. LatLonEdit::setDimension(...) was pretty broken.
Also needed/wanted a double value for the secs editor, to enable more precision.
No idea if 2 digits is a sane number of digits after the ".".
If LatLonEdit has to stay ABI compatible I will have to redo it then, as I changed the API
(removed unused/useless dimensionChanged signal and changed some method signatures).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added and viewed/edited several coords of geo bookmarks, worked all fine, same values shown after reloading or same places focussed if selected.
Also tested overflow behaviour of LatLonEdit for quite some border cases.
LatLonEdit widget still works fine in worldclock plasmoid.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/BookmarkManagerDialog.cpp <span style="color: grey">(3f9db62)</span></li>
<li>src/lib/EditBookmarkDialog.h <span style="color: grey">(4157726)</span></li>
<li>src/lib/EditBookmarkDialog.cpp <span style="color: grey">(7e36ddc)</span></li>
<li>src/lib/EditBookmarkDialog.ui <span style="color: grey">(9baf50d)</span></li>
<li>src/lib/LatLonEdit.h <span style="color: grey">(4958805)</span></li>
<li>src/lib/LatLonEdit.cpp <span style="color: grey">(758a167)</span></li>
<li>src/lib/LatLonEdit.ui <span style="color: grey">(26774d3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102608/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>