<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102373/">http://git.reviewboard.kde.org/r/102373/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Guillaume Martres.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2011, 2:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For the Satellites plugin I need a way to remove every item from the model each time the datasets are downloaded. This patch shows a buggy way to do so. It leads to a crash when clear() is called concurrently with AbstractDataPluginModell::items(), for example because of a paintEvent(), see the backtrace at http://paste.kde.org/111817/
I can't seem to find a good way to fix that without introducing locking.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/AbstractDataPluginModel.h <span style="color: grey">(1e75ba0)</span></li>
<li>src/lib/AbstractDataPluginModel.cpp <span style="color: grey">(abf77e2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102373/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>