<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102342/">http://git.reviewboard.kde.org/r/102342/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It would be great if the test could also check whether the resulting objects are accessible without crashes and whether they have the expected values (if changed or kept the same). Looks fine otherwise.</pre>
<br />
<p>- Torsten</p>
<br />
<p>On August 16th, 2011, 6:19 p.m., Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated Aug. 16, 2011, 6:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensure m_rangeCorrected is deep copied during private copy while detaching.
This avoids dangling pointers if both detached privates need to update that vector of pointers.
Thanks: Guillaume Martres for the test cases</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/geodata/data/GeoDataGeometry_p.h <span style="color: grey">(4bed8b6)</span></li>
<li>src/lib/geodata/data/GeoDataLineString_p.h <span style="color: grey">(4e87780)</span></li>
<li>tests/TestGeoDataGeometry.cpp <span style="color: grey">(dca91d1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102342/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>