<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101991/">http://git.reviewboard.kde.org/r/101991/</a>
</td>
</tr>
</table>
<br />
<p>On August 16th, 2011, 6:37 p.m., <b>Thibaut Gridel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All those are copied from other retrieve*.
I was hesitant wether to :
a) stop at first returned document, clear all other parsers and be done,
b) send one signal per succesful parsing with multiple plugins,
c) or wait till everyone finished and pick best (to be determined) result.
For now I expect plugin not to provide a valid document if they are not able to parse, and also expect only one to provide results.
The implementation therefore is b) being a bit loose on checking multiple valid results.
The expectations may change if we have for example multiple backends to parse a file. (a plugin for gpsbabel comes in mind). In such a case, we may want to go for a) through fastest (and kill other plugins, reason to keep the QList)
or c) waiting and picking best result.
On the rationale of not prospective coding, i will remove the qlist and clearing slot for now.
What do you think?</pre>
</blockquote>
<p>On August 16th, 2011, 7:07 p.m., <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, interesting insights. What about adding a proper comment, for the record? To me, it wasn't very obvious that you expect exactly one plugin to provide a useful result.
Moreover, I'm all for the principle of non-prospective coding. :)</pre>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, and please close the review when you're done. :)</pre>
<br />
<p>- Bernhard</p>
<br />
<p>On July 17th, 2011, 11:18 p.m., Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated July 17, 2011, 11:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch provides a new capability in the MarbleRunners, in order to parse files with various parsers in parallel.
It will be followed by plugins matching the current files recognised in FileLoader and GeoData parser.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Further patches integrate this framework and successfully replace existing implementation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleAbstractRunner.h <span style="color: grey">(fe01370)</span></li>
<li>src/lib/MarbleAbstractRunner.cpp <span style="color: grey">(06855f4)</span></li>
<li>src/lib/MarbleRunnerManager.h <span style="color: grey">(db4c0f3)</span></li>
<li>src/lib/MarbleRunnerManager.cpp <span style="color: grey">(cf59db5)</span></li>
<li>src/lib/RunnerPlugin.h <span style="color: grey">(8754933)</span></li>
<li>src/lib/RunnerTask.h <span style="color: grey">(d69844c)</span></li>
<li>src/lib/RunnerTask.cpp <span style="color: grey">(19047ed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101991/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>