<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101842/">http://git.reviewboard.kde.org/r/101842/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good, moves the responsibility of properties to the MarbleMap which seems a good thing.</pre>
<br />
<p>- Thibaut</p>
<br />
<p>On July 3rd, 2011, 5:07 p.m., Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Thibaut Gridel.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated July 3, 2011, 5:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes PlacemarkLayout implement LayerInterface, such that it can be rendered as part of the LayerManager infrastructure.
Due to LayerInterface::render() taking a ViewportParams instead of a ViewParams argument, determining the visibility of placemarks is now performed in MarbleMap rather than in PlacemarkLayout. Since PlacemarkLayout now holds the visibility state of placemarks, it becomes independent of any GeoScene* classes, which should make it more robust w.r.t. dereferencing GeoSceneDocument *, which may be 0.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with Plain Map toggling placemark visibility in the legend.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleMap.h <span style="color: grey">(edbd2b0)</span></li>
<li>src/lib/MarbleMap.cpp <span style="color: grey">(f641c16)</span></li>
<li>src/lib/PlacemarkLayout.h <span style="color: grey">(4b8c570)</span></li>
<li>src/lib/PlacemarkLayout.cpp <span style="color: grey">(b5f0819)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101842/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>