<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101245/">http://git.reviewboard.kde.org/r/101245/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated May 3, 2011, 10:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Uses QtSql/sqlite now to search files on disk (works on the N900 as well)
- Search term parsing is improved, supports the things described in http://userbase.kde.org/Marble/OfflineSearch
- Much improved parser, not in this patch but you can download a placemark db file from http://nienhueser.de/marble/hamburg.sqlite (3.3 MB). Place it in ~/.local/share/marble/placemarks/
- Region hierarchies still need some improvement, but that can be done later
I'll commit this soon, please speak up if you want more time to review.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the initial version of a search runner plugin that adds offline address search. I thought I'd rather push it now in an earlier stage to have the majority of the code in place before the upcoming freezes.
The patch contains the reading part: A runner plugin for Marble that works on one or more placemarks.dat files found somewhere in $MARBLE_DATADIR/maps/earth/monav/. I plan to extend the existing monav offline maps by such $country.sqlite files once the file format is reasonably stable. I'll commit the writing part (.osm parser and preprocessing) at a later point. It's only used to create .sqlite files, i.e. doesn't affect the Marble code.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mostly with http://nienhueser.de/marble/hamburg.sqlite (3.3 MB). Place that file in ~/.local/share/marble/placemarks/ and search for streets or places in Hamburg to see it running. Notice that the file format / db layout may still change a bit in the future. See http://userbase.kde.org/Marble/OfflineSearch for features expected to work.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/GoToDialog.h <span style="color: grey">(62c358f)</span></li>
<li>src/lib/GoToDialog.cpp <span style="color: grey">(caeff72)</span></li>
<li>src/lib/GoToDialog.ui <span style="color: grey">(f0756a3)</span></li>
<li>src/plugins/runner/CMakeLists.txt <span style="color: grey">(e63407a)</span></li>
<li>src/plugins/runner/local-osm-search/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/DatabaseQuery.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/DatabaseQuery.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/LocalOsmSearchRunner.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/LocalOsmSearchRunner.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/OsmDatabase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/OsmDatabase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/OsmPlacemark.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/OsmPlacemark.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/OsmRegion.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/local-osm-search/OsmRegion.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101245/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots (updated)</h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101245/s/156/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/03/marble-offline-address-search-2_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>