<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101267/">http://git.reviewboard.kde.org/r/101267/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dennis Nienhüser.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is one major part of the changes I planned to refactor the routing code towards a Qt Mobility similar API. It introduces the classes Maneuver, RouteSegment and Route based on the Qt Mobility 1.2 classes QGeoManeuver, QGeoRouteSegment and QGeoRoute. At some points I changed the API a bit for performance reasons (mostly using references/pointers instead of copying instances and introducing a few additional methods). There's no dependency to Qt Mobility, the classes and methods are just named similar to make it easier for other people to become familiar with the code.
The new classes replace some of the functionality that was previously implemented in RoutingModel (which is a good thing). The code should be easier to read now and runs significantly faster. Last but not least the position on the route is now determined accurately. Previously only the distance to supporting points of the polygon was calculated, leading to inaccurate distance estimations and unnecessary route re-calculations when the supporting points had large distances.
Please speak up if you want to review the patch and need more time, otherwise I take silence as consent and commit in the next days.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ControlView.cpp <span style="color: grey">(c52886b)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(cdc080b)</span></li>
<li>src/lib/DownloadRegionDialog.cpp <span style="color: grey">(72d84f8)</span></li>
<li>src/lib/routing/Maneuver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/routing/Maneuver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/routing/Route.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/routing/Route.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/routing/RouteSegment.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/routing/RouteSegment.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/routing/RoutingLayer.h <span style="color: grey">(29867aa)</span></li>
<li>src/lib/routing/RoutingLayer.cpp <span style="color: grey">(aba97a3)</span></li>
<li>src/lib/routing/RoutingModel.h <span style="color: grey">(0ce9496)</span></li>
<li>src/lib/routing/RoutingModel.cpp <span style="color: grey">(00d1907)</span></li>
<li>src/lib/routing/RoutingProxyModel.h <span style="color: grey">(dbcb9da)</span></li>
<li>src/lib/routing/RoutingProxyModel.cpp <span style="color: grey">(029c0fc)</span></li>
<li>src/lib/routing/RoutingWidget.cpp <span style="color: grey">(376ffb3)</span></li>
<li>src/plugins/render/routing/AudioOutput.h <span style="color: grey">(0e7f5a9)</span></li>
<li>src/plugins/render/routing/AudioOutput.cpp <span style="color: grey">(79dff98)</span></li>
<li>src/plugins/render/routing/NullAudioOutput.cpp <span style="color: grey">(4751695)</span></li>
<li>src/plugins/render/routing/RoutingPlugin.h <span style="color: grey">(6fb9752)</span></li>
<li>src/plugins/render/routing/RoutingPlugin.cpp <span style="color: grey">(dcce53e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101267/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>