<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6624/">http://svn.reviewboard.kde.org/r/6624/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble and Thibaut Gridel.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated March 30, 2011, 2:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Final patch (as committed).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">MarbleDataFacade is basically a wrapper for MarbleModel and is used in RenderPlugins. Since MarbleModel is exported, MarbleDataFacace seems redundant.
Besides porting RenderPlugins to use const MarbleModel* rather than MarbleDataFacade*, the patch introduces the following changes:
* move all models, trees, and proxies from MarbleDataFacade to MarbleModel
* introduce convenience method MarbleModel::planetId() const;
Please have a look if there lifetime issues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there are issues with plugins that appear before and after the patch is applied
* the Wikipedia plugin doesn't show items upon startup
* the solcialdesktop plugin leads to a crash when closing Marble</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/docs/release_notes/APIChanges-0.12.txt <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/AbstractDataPlugin.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/AbstractDataPluginModel.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/AbstractDataPluginModel.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/BookmarkManagerDialog.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileManager.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileViewWidget.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/LayerManager.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/LayerManager.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/PlacemarkLayout.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/fileview/FileViewFloatItem.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/graticule/GraticulePlugin.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/inhibit-screensaver/InhibitScreensaverPlugin.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleFloatItem.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/opendesktop/OpenDesktopModel.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/opendesktop/OpenDesktopModel.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/photo/PhotoPluginModel.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/photo/PhotoPluginModel.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/AbstractWeatherService.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/BBCItemGetter.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/BBCItemGetter.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/BBCWeatherService.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/BBCWeatherService.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/FakeWeatherService.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/FakeWeatherService.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/WeatherModel.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/WeatherModel.cpp <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/wikipedia/WikipediaModel.h <span style="color: grey">(1226565)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/wikipedia/WikipediaModel.cpp <span style="color: grey">(1226565)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6624/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>