<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6624/">http://svn.reviewboard.kde.org/r/6624/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, need to figure where the Online Services plugins lose track of the Model or get lost on the way... the GeometryLayer works fine so the problem doesn't seem in the layermanager.
Those are mostly cosmetics comments.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6624/diff/1/?file=45736#file45736line93" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/AbstractDataPluginModel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class AbstractDataPluginModelPrivate</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">93</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Marble<span class="hl">DataFacade</span></span> <span class="o">*</span><span class="n">m_lastDataFacade</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">93</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl"> </span><span class="k"><span class="hl">const</span></span> <span class="n">Marble<span class="hl">Model</span></span> <span class="o">*</span><span class="n">m_lastDataFacade</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could you rename the variable also?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6624/diff/1/?file=45743#file45743line66" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/LayerManager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool zValueLessThan( const LayerInterface * const one, const LayerInterface * const two )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">66</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_dataFacade</span><span class="p">(</span> <span class="n"><span class="hl">dataFacade</span></span> <span class="p">),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">64</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_dataFacade</span><span class="p">(</span> <span class="n"><span class="hl">model</span></span> <span class="p">),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you rename?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6624/diff/1/?file=45743#file45743line67" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/LayerManager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool zValueLessThan( const LayerInterface * const one, const LayerInterface * const two )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_pluginManager</span><span class="p">(</span> <span class="n">pluginManager</span> <span class="p">),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_pluginManager</span><span class="p">(</span> <span class="n"><span class="hl">model</span></span><span class="o"><span class="hl">-></span></span><span class="n">pluginManager</span><span class="p"><span class="hl">()</span></span> <span class="p">),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(Maybe OT) m_pluginManager is only used below currently. Is it expected?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6624/diff/1/?file=45745#file45745line127" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class MARBLE_EXPORT MarbleModel : public QObject</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">126</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">connectTree</span><span class="p">(</span><span class="n">bool</span> <span class="n">connect</span><span class="p">)</span> <span class="k">const</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This one was a bit of a hack...
Putting it in such a visible place as MarbleModel public will be a reason to find a more elegant way to handle model updates during file loading.
Can't we have friend for this one? (user is FileManager only)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6624/diff/1/?file=45745#file45745line240" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class MARBLE_EXPORT MarbleModel : public QObject</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">238</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">MarbleDataFacade</span><span class="o">*</span> <span class="n">dataFacade</span><span class="p">()</span> <span class="k">const</span><span class="p">;</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Need to drop the header and class MarbleDatafacade too ;)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6624/diff/1/?file=45748#file45748line63" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class MARBLE_EXPORT RenderPlugin : public QObject, public RenderPluginInterface</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Marble<span class="hl">DataFacade</span></span><span class="o">*</span> <span class="n">dataFacade</span><span class="p">()</span> <span class="k">const</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl"> </span><span class="k"><span class="hl">const</span></span> <span class="n">Marble<span class="hl">Model</span></span><span class="o">*</span> <span class="n">dataFacade</span><span class="p">()</span> <span class="k">const</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you rename?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6624/diff/1/?file=45749#file45749line43" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class RenderPluginPrivate</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Marble<span class="hl">DataFacade</span></span><span class="hl"> </span> <span class="o">*</span><span class="n">m_dataFacade</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl"> </span><span class="k"><span class="hl">const</span></span> <span class="n">Marble<span class="hl">Model</span></span> <span class="o">*</span><span class="n">m_dataFacade</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As we discussed, could you add a short comment here to remind that const prevents plugins from changing the model by design</pre>
</div>
<br />
<p>- Thibaut</p>
<br />
<p>On March 22nd, 2011, 10:42 p.m., Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated March 22, 2011, 10:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">MarbleDataFacade is basically a wrapper for MarbleModel and is used in RenderPlugins. Since MarbleModel is exported, MarbleDataFacace seems redundant.
Besides porting RenderPlugins to use const MarbleModel* rather than MarbleDataFacade*, the patch introduces the following changes:
* move all models, trees, and proxies from MarbleDataFacade to MarbleModel
* introduce convenience method MarbleModel::planetId() const;
Please have a look if there lifetime issues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there are issues with plugins that appear before and after the patch is applied
* the Wikipedia plugin doesn't show items upon startup
* the solcialdesktop plugin leads to a crash when closing Marble</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/lib/AbstractDataPlugin.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/AbstractDataPluginModel.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/AbstractDataPluginModel.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/BookmarkManagerDialog.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileManager.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileViewWidget.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/LayerManager.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/LayerManager.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/PlacemarkLayout.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/aprs/AprsPlugin.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/fileview/FileViewFloatItem.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/graticule/GraticulePlugin.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/inhibit-screensaver/InhibitScreensaverPlugin.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleFloatItem.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/opendesktop/OpenDesktopModel.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/opendesktop/OpenDesktopModel.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/photo/PhotoPluginModel.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/photo/PhotoPluginModel.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/AbstractWeatherService.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/BBCItemGetter.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/BBCItemGetter.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/BBCWeatherService.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/BBCWeatherService.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/FakeWeatherService.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/FakeWeatherService.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/WeatherModel.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/weather/WeatherModel.cpp <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/wikipedia/WikipediaModel.h <span style="color: grey">(1225659)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/wikipedia/WikipediaModel.cpp <span style="color: grey">(1225659)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6624/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>