<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6574/">http://svn.reviewboard.kde.org/r/6574/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Andrew Manson.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make it much easier to build and run marble from an IDE like QtCreator.
This change is really just a change to the cmake configuration files that copies the data into the cmake build directory while cmake is being run. Any code changes are just to facilitate looking relative to the executable for data files.
This is a proof of concept patch and needs discussion. Once approved the rest of the Data marble/data/CMakeLists.txt file can be converted to using the new handy macro with very little effort. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have only tested this running the QT_ONLY version from within qtcreator. I have not tested running "make install" but I am confident that I have not changed any of the logic in the CMake Script so the install path should not have changed. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeedu/marble/data/CMakeLists.txt <span style="color: grey">(1223576)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MapThemeManager.cpp <span style="color: grey">(1223576)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MarbleDirs.h <span style="color: grey">(1223576)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MarbleDirs.cpp <span style="color: grey">(1223576)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6574/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>