<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6250/">http://svn.reviewboard.kde.org/r/6250/</a>
     </td>
    </tr>
   </table>
   <br />









<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://svn.reviewboard.kde.org/r/6250/diff/2/?file=43341#file43341line36" style="color: black; font-weight: bold; text-decoration: underline;">/branches/KDE/4.6/kdeedu/marble/src/lib/TextureColorizer.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">36</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">typedef</span> <span class="k">struct</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">36</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">class</span> <span class="nc">GpFifo</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This name is back from the time when Marble was not in kdeedu yet and was still named Globepedia. Let&#39;s use a better name for the class, like &quot;EmbossFifo&quot; or something like that.</pre>
</div>
<br />



<p>- Torsten</p>


<br />
<p>On December 31st, 2010, 3:46 p.m., Bernhard Beschow wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for marble.</div>
<div>By Bernhard Beschow.</div>


<p style="color: grey;"><i>Updated 2010-12-31 15:46:04</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is an attempt to accellerate the tile-scaling approach even further using cached QPixmaps.

Note that this patch is claimed to be binary compatible to KDE 4.6 (Marble 1.0).</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* I get ~4x speedups on my system (up to 130 fps with --timedemo, depending on the map theme)
* Earthwings measured ~2x speedup on the N900 (up to 5.9 fps with --timedemo)</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/AbstractScanlineTextureMapper.h <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/EquirectScanlineTextureMapper.h <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/EquirectScanlineTextureMapper.cpp <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/MercatorScanlineTextureMapper.h <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/MercatorScanlineTextureMapper.cpp <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/SphericalScanlineTextureMapper.h <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/SphericalScanlineTextureMapper.cpp <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/StackedTileLoader.h <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/StackedTileLoader.cpp <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/TextureColorizer.h <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/TextureColorizer.cpp <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/TextureLayer.cpp <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/TileScalingTextureMapper.h <span style="color: grey">(1210469)</span></li>

 <li>/branches/KDE/4.6/kdeedu/marble/src/lib/TileScalingTextureMapper.cpp <span style="color: grey">(1210469)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6250/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>