<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6070/">http://svn.reviewboard.kde.org/r/6070/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6070/diff/10/?file=43116#file43116line684" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp</a>
<span style="font-weight: normal;">
(Diff revision 10)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MapWizard::suggestPreviewImage()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">684</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">tempPreview</span><span class="p">.</span><span class="n">save</span><span class="p">(</span> <span class="s">"/tmp/previewImage.png"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please use QTemporaryFile for all "/tmp" incidents. "/tmp" will certainly not work on Windows. And of course we need to ensure crossplatformness.</pre>
</div>
<br />
<p>- Torsten</p>
<br />
<p>On December 25th, 2010, 8:01 a.m., Utku Aydin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble, Torsten Rahn and Dennis Nienhüser.</div>
<div>By Utku Aydin.</div>
<p style="color: grey;"><i>Updated 2010-12-25 08:01:44</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Map wizard helps users create a new map easily.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested WMS and online map cases with different servers and source bitmap case with different source images.
* Validates the data properly.
* Creates the legend.
* Downloads and shows tiles from both WMS and a static HTTP URL properly.
Tested servers:
* http://onearth.jpl.nasa.gov/wms.cgi (WMS)
* http://tile.openstreetmap.org (online map)
* http://andy.sandbox.cloudmade.com/tiles/cycle/ (online map)
* http://mt.google.com/vt/lrys=m@130&hl=tr&x={x}&y={y}&z={zoomLevel}&s=Ga
Note:
I didn't test upload feature because the server is not available at the moment.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeedu/marble/src/ControlView.h <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/ControlView.cpp <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/QtMainWindow.h <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.h <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.cpp <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.ui <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MapWizard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MapWizard.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.h <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.h <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.cpp <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/marble.kcfg <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/marble_part.h <span style="color: grey">(1207748)</span></li>
<li>trunk/KDE/kdeedu/marble/src/marble_part.cpp <span style="color: grey">(1207748)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6070/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/6070/s/577/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/08/wizard1_400x100.png" style="border: 1px black solid;" alt="Step One" /></a>
<a href="http://svn.reviewboard.kde.org/r/6070/s/578/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/08/wizard2_400x100.png" style="border: 1px black solid;" alt="Step Two" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>