<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6070/">http://svn.reviewboard.kde.org/r/6070/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On December 14th, 2010, 9:51 p.m., <b>Torsten Rahn</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great work. Could you resolve the remaining minor issues that I pointed out? :-)</pre>
 </blockquote>




 <p>On December 15th, 2010, 12:25 p.m., <b>Utku Aydin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">They are resolved in diff r5, thanks for pointing out.</pre>
 </blockquote>





 <p>On December 16th, 2010, 2:25 p.m., <b>Alexandre Viard</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A small case problem remain in marble_part.cpp line 615 : setWMSServices instead of SetWmsServices</pre>
 </blockquote>








</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alexandre: Good catch. Yes, that needs to be fixed.</pre>
<br />








<p>- Torsten</p>


<br />
<p>On December 15th, 2010, 12:24 p.m., Utku Aydin wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for marble, Torsten Rahn and Dennis Nienhüser.</div>
<div>By Utku Aydin.</div>


<p style="color: grey;"><i>Updated 2010-12-15 12:24:57</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Map wizard helps users create a new map easily.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested the wizard in different situations and it doesn&#39;t let the user overwrite the existing maps. Also it warns the user properly if there is an invalid input.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdeedu/marble/src/QtMainWindow.h <span style="color: grey">(1206280)</span></li>

 <li>trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp <span style="color: grey">(1206280)</span></li>

 <li>trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt <span style="color: grey">(1206280)</span></li>

 <li>trunk/KDE/kdeedu/marble/src/lib/MapViewWidget.ui <span style="color: grey">(1206280)</span></li>

 <li>trunk/KDE/kdeedu/marble/src/lib/MapWizard.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdeedu/marble/src/lib/MapWizard.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.h <span style="color: grey">(1206280)</span></li>

 <li>trunk/KDE/kdeedu/marble/src/lib/MarbleThemeSelectView.cpp <span style="color: grey">(1206280)</span></li>

 <li>trunk/KDE/kdeedu/marble/src/marble.kcfg <span style="color: grey">(1206280)</span></li>

 <li>trunk/KDE/kdeedu/marble/src/marble_part.h <span style="color: grey">(1206280)</span></li>

 <li>trunk/KDE/kdeedu/marble/src/marble_part.cpp <span style="color: grey">(1206280)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6070/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://svn.reviewboard.kde.org/r/6070/s/577/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/08/wizard1_400x100.png" style="border: 1px black solid;" alt="Step One" /></a>

 <a href="http://svn.reviewboard.kde.org/r/6070/s/578/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/08/wizard2_400x100.png" style="border: 1px black solid;" alt="Step Two" /></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>