<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6122/">http://svn.reviewboard.kde.org/r/6122/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 15th, 2010, 9:25 p.m., <b>Michael Hansen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine - but why have YesNoCancel, when there is not really a difference between No and Cancel?
Thanks for the quick fix,
Michael</pre>
</blockquote>
<p>On December 15th, 2010, 9:26 p.m., <b>Michael Hansen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just to confirm: I tested the KDE version!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the quick test.
To decide whether to answer 'Yes' or 'No' to a question, you have to read it. If you only want to get out of a dialog (because you're unsure or just clicked on the wrong button), 'Cancel' will always be the right choice without even reading the text.
Arguably one could strip it down to 'Yes' and 'Cancel', but I think the three-button version one is more common.
</pre>
<br />
<p>- Dennis</p>
<br />
<p>On December 15th, 2010, 9:11 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated 2010-12-15 21:11:08</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds a confirmation dialog to the Qt and KDE applications shown to confirm the deletion of bookmarks. Can I get a quick test for the KDE version, please? Mine has a corrupt UI since some time and somehow I'm not able to fix that (the menu is totally screwed up, no actions except the help menu. Recompiling from scratch doesn't help).
The new string is already acknowledged by translators, so let's get this in quickly before they change their minds. Thanks.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine in Qt, but needs someone to test in the KDE version.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=259655">259655</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp <span style="color: grey">(1206537)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/marble_part.cpp <span style="color: grey">(1206537)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6122/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>