<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5995/">http://svn.reviewboard.kde.org/r/5995/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 28th, 2010, 9:40 p.m., <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marbleous patch :-) I like it and I think it could go in as is. All the comments I made below are just suggestions for further improvment :-)
Just wondering: Is the Tutorial you used to create the patch 100% correct? Or has anything changed that needs to be corrected in the Tutorial? If so it would be great if you could make corrections to the Tutorial (if you haven't done so already).
Again great work! Thanks a lot!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you. Tutorial is perfect, I just needed to find out how to draw an arc, that's all.</pre>
<br />
<p>- Utku</p>
<br />
<p>On November 28th, 2010, 5:25 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated 2010-11-28 17:25:24</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch adds an online service that displays recent (up to one month ago) earthquake in the viewport.
Merely acting as a proxy for this review request: The patch is based on the excellent work of Utku Aydin in a Google Code-in task. I just added the seismograph background svg, changed the sort order to earthquake magnitude (i.e. the twenty earthquakes with highest magnitude are shown on the screen) and adjusted the code style to Marble's.
I'll delay the commit until 4.6 is branched off.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt <span style="color: grey">(1201749)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/earthquake.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/seismograph.svg <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5995/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5995/s/565/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/11/28/Marble-CodeIn-Earthquakes_400x100.png" style="border: 1px black solid;" alt="Earthquake Plugin" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>