<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4461/">http://svn.reviewboard.kde.org/r/4461/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 16th, 2010, 11:22 p.m., <b>Markus Slopianka</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the "Edit Map" menu entry should be in the Edit menu. Where else would a menu entry about editing be other than that menu? ;-)
Looking at your editor selection screenshot, I think it's not the perfect solution for the following reasons:
1.) For only a rather short list drop down menus are counterproductive. Simple radio buttons work better usability-wise in cases for up to ~5 possible options.
2.) I don't think screenshots are needed. The map view in all editors looks rather similar anyway, meaning the screenshots don't add any value.
3.) The editor descriptions suck. ;-) Every one of those three editors "is an OpenStreetMap editor using the WYSIWYG (what you see is what you get) principle", not only Meerkartor. ;-) I don't have good descriptions available right now but it'll be helpful to merge this patch long enough before the string freeze to allow me or someone else to refine the descriptions. :-)</pre>
</blockquote>
<p>On September 17th, 2010, 6:09 a.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> I think the "Edit Map" menu entry should be in the Edit menu. Where else would a menu entry about editing be other than that menu? ;-)
It still is, why do you think it moved elsewhere? The dialog in the screenshot is invoked at the first time when no preference for any editor is set by the user.
> Simple radio buttons work better usability-wise in cases for up to ~5 possible options.
Where did you get that number from? KDE HIG says three [1] and I'd expect to see Osm2Go [2] there soon, making it four.
> The map view in all editors looks rather similar anyway, meaning the screenshots don't add any value.
I wonder why we provide map themes in Marble, they all look rather similar as well ;-)
> The editor descriptions suck. ;-)
Why don't you suggest better descriptions now instead of delaying it to some mystic later point?
[1] http://techbase.kde.org/Projects/Usability/HIG/Combo_Box
[2] http://wiki.openstreetmap.org/wiki/Osm2go
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you've actually read my comment, I wrote that at time of writing I didn't have better descriptions. Now I do and I'm about to commit them. Here they are:
Merkaartor is an OpenStreetMap editor that is powerful and easy to use. It integrates well into the used workspace.
JOSM is a powerful OpenStreetMap editor which is more complex to use that other editors. It is built on the Java platform and therefor runs on all systems for which Java is available but does not integrate well into the workspace. A Java SE-compatible runtime is required.
Potlatch is a very easy to use OpenStreetMap editor, though lacks the power of Merkaartor and JOSM. It runs on all platforms for which web browsers with Flash support are available. Performance of Potlatch is depending on the quality of the installed Flash version.</pre>
<br />
<p>- Markus</p>
<br />
<p>On September 16th, 2010, 8:48 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated 2010-09-16 20:48:27</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds an "Edit Map Externally" menu item in the main application (currently Qt only) that does either:
- open a web browser using potlatch (flash based osm builtin map editor) at the current view (default)
- execute josm or merkaartor (whichever is enabled in settings)
- update a running josm or merkaartor if they opened a server at localhost:8111
The choice which application to use (potlatch, josm, merkaartor) is left to the user. A running server is detected automatically if josm or merkaartor is selected by the user. The default choice is potlatch because it will be usable for most users out of the box (requirements are a web browser with flash support).
Most of the implementation is done in ControlView, i.e. outside lib/, but easily shareable between qt and kde main applications. I can implement it in its own class if you think it clutters ControlView too much.
The edit button is visible always currently. It may be better to hide it for map views other than openstreetmap to avoid confusing users.
Please note that josm and merkaartor should not be too outdated, especially for their server applications.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with konqueror for potlatch. Tested Merkaartor 0.16.1. Merkaartor 0.16.0 may work (not tested), older versions lack the server. Tested josm version 3329. Note that you need to enable the server explicitly for merkaartor (tools => settings => network) and josm (edit => preferences => plugins, install and enable the remotecontrol plugin)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=240968">240968</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/ControlView.h <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/ControlView.cpp <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/QtMainWindow.h <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/ExternalEditor.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/ExternalEditorDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/ExternalEditorDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleNavigationSettingsWidget.ui <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/QtMarbleConfigDialog.h <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/QtMarbleConfigDialog.cpp <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/marble.qrc <span style="color: grey">(1175778)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4461/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/4461/s/504/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/16/marble-external-map-editor-selection_400x100.png" style="border: 1px black solid;" alt="marble-external-map-editor-selection.png" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>