<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5485/">http://svn.reviewboard.kde.org/r/5485/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble and Torsten Rahn.</div>
<div>By Dennis Nienhüser.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes the routing start/destination user interface:
- Use one button instead of two ("remove" button on the right isn't perfect on Maemo)
- Decouple the double-use of the left button ("map input" vs. "center map here")
- Add the possibility to choose a bookmark or the current location as target position
The only drawback I see is that it adds a new menu, i.e. another click and less obvious interface. Another option would be to add a third button with a drop down like this which only has "from map", "bookmark" and "current location" as menu actions. But I'd rather not have three buttons given the rather restricted space we have.
Please review with usability in mind ;-) and make sure to look at the screenshot, it should give a good overview of the changes.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Desktop version only so far, will test on Maemo later.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingWidget.cpp <span style="color: grey">(1181012)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingInputWidget.cpp <span style="color: grey">(1181012)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingInputWidget.h <span style="color: grey">(1181012)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5485/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5485/s/516/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/29/marble-routing-input-gui_400x100.png" style="border: 1px black solid;" alt="Routing Input GUI Changes" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>