<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4461/">http://svn.reviewboard.kde.org/r/4461/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 27th, 2010, 12:13 a.m., <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4461/diff/3/?file=36109#file36109line45" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/marble.qrc</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <file>../data/editors/potlatch.png</file></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What size are these? Would it maybe be better to save these as 85-90% quality JPGs?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">They are 15, 27 and 28 kb. Jpgs at 85% are more than double the size of the pngs.</pre>
<br />
<p>- Dennis</p>
<br />
<p>On September 16th, 2010, 8:48 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated 2010-09-16 20:48:27</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds an "Edit Map Externally" menu item in the main application (currently Qt only) that does either:
- open a web browser using potlatch (flash based osm builtin map editor) at the current view (default)
- execute josm or merkaartor (whichever is enabled in settings)
- update a running josm or merkaartor if they opened a server at localhost:8111
The choice which application to use (potlatch, josm, merkaartor) is left to the user. A running server is detected automatically if josm or merkaartor is selected by the user. The default choice is potlatch because it will be usable for most users out of the box (requirements are a web browser with flash support).
Most of the implementation is done in ControlView, i.e. outside lib/, but easily shareable between qt and kde main applications. I can implement it in its own class if you think it clutters ControlView too much.
The edit button is visible always currently. It may be better to hide it for map views other than openstreetmap to avoid confusing users.
Please note that josm and merkaartor should not be too outdated, especially for their server applications.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with konqueror for potlatch. Tested Merkaartor 0.16.1. Merkaartor 0.16.0 may work (not tested), older versions lack the server. Tested josm version 3329. Note that you need to enable the server explicitly for merkaartor (tools => settings => network) and josm (edit => preferences => plugins, install and enable the remotecontrol plugin)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=240968">240968</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/ControlView.h <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/ControlView.cpp <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/QtMainWindow.h <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/ExternalEditor.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/ExternalEditorDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/ExternalEditorDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleNavigationSettingsWidget.ui <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/QtMarbleConfigDialog.h <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/QtMarbleConfigDialog.cpp <span style="color: grey">(1175778)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/marble.qrc <span style="color: grey">(1175778)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4461/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/4461/s/504/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/16/marble-external-map-editor-selection_400x100.png" style="border: 1px black solid;" alt="marble-external-map-editor-selection.png" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>