<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5254/">http://svn.reviewboard.kde.org/r/5254/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Damn, your patches are always so nicely done. Coding Guidelines are followed, the APIs are spot on, the implementation is always extremely elegant and seems to be aware of every single subtle detail in Marble (have you learned Marble's source code by heart yet?). </pre>
<br />
<p>- Torsten</p>
<br />
<p>On September 4th, 2010, 10:49 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated 2010-09-04 22:49:02</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extends the print dialog (X11 only, I'm afraid) with a new tab to configure Marble related print options: Toggle whether the map, the background (outer space), the legend, route summary and/or driving instructions are printed. The default values should be sane -- map is always checked by default, legend never. Background is not checked by default and is only enabled if the map does not cover the viewport. The routing options are checked if a route exists, and disabled otherwise.
Most of the code lies in ControlView to be used by the Qt and KDE version commonly. It may be possible to move it to MarbleWidget/MarbleModel to have it in the lib, but we need to agree on a way how to set the print options then.
The patch adds two new members to MarbleModel: The legend as a QTextDocument and a boolean controlling whether the background (background color =~ outer space and plugins like stars painting on it) is painted.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Globe without background and with legend: http://nienhueser.de/marble/marble-globe.pdf
Route with driving instructions: http://nienhueser.de/marble/marble-route.pdf
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=241551">241551</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/ControlView.h <span style="color: grey">(1171700)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/ControlView.cpp <span style="color: grey">(1171700)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt <span style="color: grey">(1171700)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleLegendBrowser.cpp <span style="color: grey">(1171700)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h <span style="color: grey">(1171700)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp <span style="color: grey">(1171700)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp <span style="color: grey">(1171700)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/PrintOptions.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/PrintOptionsWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/PrintOptionsWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h <span style="color: grey">(1171700)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp <span style="color: grey">(1171700)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5254/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5254/s/495/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/04/marble-print-options_400x100.png" style="border: 1px black solid;" alt="marble-print-options.png" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>