<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5264/">http://svn.reviewboard.kde.org/r/5264/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 11th, 2010, 8:28 a.m., <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice. Code looks good. I've tested it and the UI changes are good as well (I need to create some icons though ..). Ship it!
I think the direction stuff is lacking a bit feedback still to let the user know that Marble is evaluating the route .... Currently I click the points. Nothing seems to happen. Then the route is drawn and then there is a situation where I don't know whether I'll receive driving instructions eventually ....</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, true. I plan to rewrite the route difference estimation as I have a feeling that it's awfully slow for longer routes. Ideally there shouldn't be a noticeable delay like there is now.
</pre>
<br />
<p>- Dennis</p>
<br />
<p>On September 5th, 2010, 12:52 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated 2010-09-05 12:52:56</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Google Maps and other services made people used to "Directions from here" and "Directions to here" context menu entries. This patch adds them to Marble.
Note that this will make the Routing feature available to applications embedding a MarbleWidget, though in this scenario the two actions do not work yet (they'll do nothing). I expect to fix that in time for 4.6 though when working on https://bugs.kde.org/show_bug.cgi?id=248086
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Various combinations of empty and existing routes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/KDE/4.5/kdeedu/marble/src/lib/MarbleWidgetPopupMenu.h <span style="color: grey">(1171823)</span></li>
<li>/branches/KDE/4.5/kdeedu/marble/src/lib/MarbleWidgetPopupMenu.cpp <span style="color: grey">(1171823)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5264/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>