<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5292/">http://svn.reviewboard.kde.org/r/5292/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">simplifies extendeddata feeding and complies better with the spec indeed.</pre>
<br />
<p>- Thibaut</p>
<br />
<p>On September 8th, 2010, 7:02 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated 2010-09-08 19:02:53</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Our implementation of the kml Data element currently lacks the name attribute and uses the displayName instead, which is not correct. This leads to <Data> tags with empty name attributes being written if the (optional) displayName is not set.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp <span style="color: grey">(1172715)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp <span style="color: grey">(1172715)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.h <span style="color: grey">(1172715)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData.cpp <span style="color: grey">(1172715)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataData_p.h <span style="color: grey">(1172715)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.h <span style="color: grey">(1172715)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataExtendedData.cpp <span style="color: grey">(1172715)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlDataTagHandler.cpp <span style="color: grey">(1172715)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDataTagWriter.cpp <span style="color: grey">(1172715)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/runner/gosmore/GosmoreRunner.cpp <span style="color: grey">(1172715)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/runner/nominatim/OsmNominatimRunner.cpp <span style="color: grey">(1172715)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/runner/routino/RoutinoRunner.cpp <span style="color: grey">(1172715)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5292/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>