<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4990/">http://reviewboard.kde.org/r/4990/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me.</pre>
<br />
<p>- Torsten</p>
<br />
<p>On August 11th, 2010, 11:13 p.m., Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated 2010-08-11 23:13:40</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The GeometryLayer is added as a permanent layer in MarbleModel, because we need to rely on this layer without a plugin.
There are many fixes compared to the GeoRender code:
- it is not a Model/View class anymore as that brought a lot of unused boilerplate and we don't react to model signals anyway
- no more hacks to try and determine styling on the fly, this is delegated after file loading in PlacemarkManager
- internal data in private class
GeoDataFeature::style now points at the current style identified in the document. The setStyle doesn't do it (yet)
There is a conflict between the geodatadocument style and the VisualCategory one. Please check that I didn't break too much there...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Loaded various kml/pnt/gpx files (including Marble Writing).
Displayed positiontracking track.
Rendering unchanged for the most (default styling now is that of GeoDataVisualCategory::Default)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileManager.h <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/GeometryLayer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/GeometryLayer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/PlacemarkManager.h <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/PlacemarkManager.cpp <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/geodata/CMakeLists.txt <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererPlugin.h <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererPlugin.cpp <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.h <span style="color: grey">(1162401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.cpp <span style="color: grey">(1162401)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4990/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>