<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4988/">http://reviewboard.kde.org/r/4988/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not a complete review, yet, but my first thoughts:</pre>
 <br />





<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="/r/4988/diff/1/?file=33664#file33664line639" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MarbleModel::paintGlobe( GeoPainter *painter,</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">639</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span class="k">break</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks strange to me. Do we only paint the one layer then and never multiple ones?</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="/r/4988/diff/1/?file=33664#file33664line1142" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GeoSceneTexture * MarbleModel::textureLayer() const</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1142</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="k">for</span> <span class="p">(</span> <span class="p">;</span> <span class="n">it</span> <span class="o">!=</span> <span class="n">end</span><span class="p">;</span> <span class="o">++</span><span class="n">it</span> <span class="p">)</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seeing this part of code (or similar) for the 3rd or 4th time lets me think we really need to copy this code that often.</pre>
</div>
<br />



<p>- Bastian</p>


<br />
<p>On August 11th, 2010, 9:37 p.m., hjain wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for marble and Bastian Holst.</div>
<div>By hjain.</div>


<p style="color: grey;"><i>Updated 2010-08-11 21:37:38</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch merges Temperature(July) and Temperature(Dec) themes into Temperature theme by using dgml time tag. Similar, for Precipitation themes.
Kindly download the earth folder from http://uploading.com/files/5e9755bd/earth.tar.gz/ and replace it with marble/data/maps/earth folder.</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdeedu/marble/data/CMakeLists.txt <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/precip-dec/precip-dec-preview.png <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/precip-dec/precip-dec.dgml <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/precip-jul/precip-jul.jpg <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/precip/precip-preview.png <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/precip/precip.dgml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/temp-dec/temp-dec-preview.png <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/temp-dec/temp-dec.dgml <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/temp-jul/temp-jul.jpg <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/temp/temp-preview.png <span style="color: grey">(UNKNOWN)</span></li>

 <li>/trunk/KDE/kdeedu/marble/data/maps/earth/temp/temp.dgml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/MarbleClock.h <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/MarbleClock.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/StackedTileLoader.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlElementDictionary.h <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlElementDictionary.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlTimeTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/dgml/DgmlTimeTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLayer.h <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLayer.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneMap.h <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneMap.cpp <span style="color: grey">(1162190)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/marble_part.rc <span style="color: grey">(1162190)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4988/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>