<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4728/">http://reviewboard.kde.org/r/4728/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>Looks good. Please fix the remaining issues and commit to svn trunk :-)</pre>
<br />
<p>- Dennis</p>
<br />
<p>On July 26th, 2010, 9:37 p.m., Siddharth Srivastava wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Siddharth Srivastava.</div>
<p style="color: grey;"><i>Updated 2010-07-26 21:37:16</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Added "Auto Recentering and Auto Zooming" support for navigation mode. Auto Recentering has two options:
(i) The current gps location is always at the center of the map (ii)The gps location is moved to the center of the map when required according to the custom area predefined according to the size of the map.
"Current Routing Instructions" are shown to the user while navigating through the route calculated. A plugin is added to show the time and distance remaining as well as the total distance covered on the route. When an instruction is selected the portion of the route where the instruction is valid gets highlighted. The instruction also appears a certain time before a user reaches it.
"Downloading of maps for offline mode" is implemented. For calculating the region to be downloaded an offset(in meters) around the calculated route and the required tile level ranges to be downloaded need to be specified. A default offset is used in case user doesn't specify any offset.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">"Auto Recentering and Auto Zooming"- testing done on various gps tracks available. All possible combinations of Auto Zoom and the two modes of auto recentering were tested.
"Current Routing Instructions" - testing done on various routes calculated using osmprovider as well as yoursnavigation provider and the gps tracks. Testing also done with and without plugin.
"Downloading of maps for offline mode"- testing done for various routes around the world using orsprovider and yoursnavigation provider.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/ControlView.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.ui <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/LatLonBoxWidget.ui <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleMath.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/PositionProviderPlugin.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/PositionProviderPlugin.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/TileCoordsPyramid.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/TileCoordsPyramid.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLineString.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataLineString.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/global.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/graphicsview/MarbleGraphicsItem.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingWidget.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.h <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/CMakeLists.txt <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingItemWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp <span style="color: grey">(1155009)</span></li>
<li>/trunk/KDE/kdeedu/marble/tests/TestGeoData.cpp <span style="color: grey">(1155009)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4728/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>