<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4441/">http://reviewboard.kde.org/r/4441/</a>
</td>
</tr>
</table>
<br />
<pre>Hi, I think you want to close this one, I pushed my long series of changes for Pointer-based GeoData into trunk, i.e. for 4.6.</pre>
<br />
<p>- Thibaut</p>
<br />
<p>On June 23rd, 2010, 4:20 a.m., 1989gaurav wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By 1989gaurav.</div>
<p style="color: grey;"><i>Updated 2010-06-23 04:20:33</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Modified GeoDataContainer and converted it to hold Pointers to GeoDataFeature. Most of the feature working properly but getting some test failed.
When I insert a folder or placemark in a document all tests works fine but when placemarks are added into the folders in document I'm getting some failed tests. Please suggest me where I am going wrong.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">run TestGeoData inside marble-build/tests/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp <span style="color: grey">(1140163)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.h <span style="color: grey">(1140644)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.cpp <span style="color: grey">(1140644)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer_p.h <span style="color: grey">(1140644)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFolder.h <span style="color: grey">(1140644)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.h <span style="color: grey">(1140644)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.cpp <span style="color: grey">(1140644)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h <span style="color: grey">(1140644)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/marble/tests/TestGeoData.cpp <span style="color: grey">(1140163)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4441/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>