<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4285/">http://reviewboard.kde.org/r/4285/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 9th, 2010, 9:36 a.m., <b>Bastian Holst</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>Your patch introduced a lot of compiler warning:
[ 21%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataFolder.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature_p.h:20,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataContainer_p.h:14,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFolder.cpp:27:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 21%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataObject.o
[ 22%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataAbstractView.o
[ 22%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataCoordinates.o
[ 22%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLineString.o
[ 22%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataContainer.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature_p.h:20,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataContainer_p.h:14,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataContainer.cpp:15:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 22%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLinearRing.o
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataColorStyle.o
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataRegion.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.cpp:13:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataPolyStyle.o
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataStyleMap.o
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataStyle.o
[ 23%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataIconStyle.o
[ 24%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLookAt.o
[ 24%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataDocument.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature_p.h:20,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataContainer_p.h:14,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataDocument_p.h:16,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataDocument.cpp:24:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 24%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLatLonBox.o
[ 24%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataHotSpot.o
[ 24%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataExtendedData.o
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLod.o
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLatLonAltBox.o
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataLabelStyle.o
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataGeometry.o
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataPlacemark.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature_p.h:20,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataPlacemark_p.h:14,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataPlacemark.cpp:18:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 25%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/data/GeoDataFeature.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature_p.h:20,
from /home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataFeature.cpp:14:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 26%] Building
[ 37%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlLatLonAltBoxTagHandler.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/handlers/kml/KmlLatLonAltBoxTagHandler.cpp:18:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
[ 37%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlColorModeTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlFolderTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlDescriptionTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlHrefTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlExtendedDataTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlCountrycodeTagHandler.o
[ 38%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlWidthTagHandler.o
[ 39%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/Kml_scaleTagHandler.o
[ 39%] Building CXX object src/lib/CMakeFiles/marblewidget.dir/geodata/handlers/kml/KmlLodTagHandler.o
In file included from /home/bastian/devel/kde/marble/src/lib/geodata/handlers/kml/KmlLodTagHandler.cpp:18:
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataObject.h:64: warning: ‘virtual void Marble::GeoDataObject::setParent(Marble::GeoDataObject*)’ was hidden
/home/bastian/devel/kde/marble/src/lib/geodata/data/GeoDataRegion.h:89: warning: by ‘void Marble::GeoDataRegion::setParent(Marble::GeoDataFeature*)’
</pre>
</blockquote>
<p>On July 9th, 2010, 4:37 p.m., <b>Thibaut Gridel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>missing virtual in front of GeoDataRegion::setParent() declaration! fixed.</pre>
</blockquote>
</blockquote>
<pre>was missing a virtual in GeoDataRegion::setParent declaration. Fixed!</pre>
<br />
<p>- Thibaut</p>
<br />
<p>On July 8th, 2010, 6:08 p.m., Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated 2010-07-08 18:08:35</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">providing a (naive) pointer-based api for GeoDataContainer, and test case which shows early breaks...
Toggle between the two "document.append(folder);" shows how brittle the api still is.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Run TestGeoData :(</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileManager.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleGeometryModel.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleGeometryModel.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer_p.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFolder.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataGeometry.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry_p.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDocumentTagWriter.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererPlugin.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.h <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.cpp <span style="color: grey">(1147288)</span></li>
<li>/trunk/KDE/kdeedu/marble/tests/TestGeoData.cpp <span style="color: grey">(1147288)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4285/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>