<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4285/">http://reviewboard.kde.org/r/4285/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated 2010-06-27 21:46:09.252277</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This updated diff is the result of the following changes (squashed together so that it fits reviewboard)
- GeoDataObject: provide parent()
- GeoDataContainer: store GeoDataFeature* in GeoDataContainer
also provide a pointer-based api which doesn't detach() to access a pointer
last, use iterators for GeoDataFeature* to iterate features
- GeoData: showcase test for pointer-based GeoDataContainer
- FileManager takes over geodatadocument ownership (hence FileManager::closeFile and not FileLoader does the delete, and KmlFileViewItem stores a pointer to this document)
- GeoDataMultiGeometry: store GeoDataGeometry* in GeoDataMultiGeometry and provides same pointer-based api
- GeoData: dead code for GeoDataObject, GeoDataFeature, GeoDataGeometry and GeoDataPlacemark
- GeoDataTreeModel, a model that works(TM)
- PositionTracking: append GeoDataDocument to FileManager directly (and so don't use geometrymodel)
- GeoRenderer: use the GeoDataTreeModel (and so don't use geometrymodel either)
- drop the MarbleGeometryModel
Remaining points:
- Parser code should use the pointer-based api to store features and geometries in a sane way
- GeoDataTreeModel should not have to fix parenting
- PlacemarkManager and model should use either pointer-based data or even better rely on GeoDataTreeModel
Tests/ New Features:
- GeoDataTreeModel passes the ModelTest test harnessing, meaning it is a real model, and supports a treeview
- Now multiple documents containing geometries can be rendered!
- PositionTracking feeds one of those, and it is available in the FileManager</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">providing a (naive) pointer-based api for GeoDataContainer, and test case which shows early breaks...
Toggle between the two "document.append(folder);" shows how brittle the api still is.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Run TestGeoData :(</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileManager.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/KmlFileViewItem.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleDataFacade.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleGeometryModel.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleGeometryModel.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataContainer_p.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFolder.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataGeometry.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataMultiGeometry_p.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataObject.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataPlacemark.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDocumentTagWriter.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererPlugin.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.h <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/geodata/GeoRendererView.cpp <span style="color: grey">(1143093)</span></li>
<li>/trunk/KDE/kdeedu/marble/tests/TestGeoData.cpp <span style="color: grey">(1143093)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4285/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>