<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4410/">http://reviewboard.kde.org/r/4410/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Wes Hardaker.</div>
<p style="color: grey;"><i>Updated 2010-06-21 18:28:27.302695</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">removed another unneeded cast from the QtMain file. (the kde counterpart already had it removed).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This patch adds a renderType() function for determining the type of plugin it is and where the action() should be placed (eg, in the online menu). Previously it was using a cast check and thus limited the types of actions that can be placed into the online menu to only things of a certain class tree.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Not much, since current SVN trunk crashes immediately on start up for me. But it should be safe.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp <span style="color: grey">(1140837)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/AbstractDataPlugin.h <span style="color: grey">(1140837)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/AbstractDataPlugin.cpp <span style="color: grey">(1140837)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.h <span style="color: grey">(1140837)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.cpp <span style="color: grey">(1140837)</span></li>
<li>trunk/KDE/kdeedu/marble/src/marble_part.cpp <span style="color: grey">(1140837)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4410/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>