<br><br><div class="gmail_quote">On Thu, Apr 8, 2010 at 5:29 PM, Bastian Holst <span dir="ltr"><<a href="mailto:bastianholst@gmx.de" target="_blank">bastianholst@gmx.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi Gabriel,<br>
<br>
Thanks for being interested in Marble Junior Jobs. I think the idea of the<br>
Junior Job was quite different, but that shouldn't stop you from implementing<br>
your idea.<br></blockquote><div><br>Oh, sorry. Good thing I didn't finish that up before sending a patch. But yeah, I guess I could do both then. <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
We were thinking about the QIcon which is returned by WikipediaPlugin::icon()<br>
to have an icon in the menu. For some reason someone moved this initialization<br>
of the icon outside of the constructor of WikipediaPlugin, so the icon<br>
dissappeared from the menu. [1] should fix this issue.<br></blockquote><div><br>Ok, got it. <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
You seem to be thinking of the icon (Wikipedia or Photo) which is displayed on<br>
the Photo itself or as a substitute to reduce network load, as it's done in<br>
the Wikipedia code.<br></blockquote><div><br>Yes <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
About your patch: What you have done seems like a good start, but I don't<br>
think that it is needed to prerender this image. QIcon could take the svg<br>
directly and I think (but I'm not sure), QIcon does this optimization itself.<br>
Perhaps you could run some tests or look this up in the Qt documentation to<br>
find out if I'm right. Additionally the caching of the ScreenGraphicsItem<br>
should hold the system load down.<br>
If this is not the case, please change the WikipediaPlugin, too.<br>
Additionally my old code seems to be a bit easier to read, so this should be<br>
preferred if there are minor or no speed differences.<br></blockquote><div><br>thanks for the tips :) <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Again thanks for your work!<br></blockquote><div><br>No problem. <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Best regards<br>
Bastian<br>
<br>
<br>
[1] <a href="http://websvn.kde.org/?view=rev&revision=1112698" target="_blank">http://websvn.kde.org/?view=rev&revision=1112698</a><br>
<br>
Am Donnerstag, 8. April 2010 20.09:11 schrieb Gabriel Joel Perez:<br>
<div><div></div><div>> Hello!<br>
><br>
> I was looking around at the Mable junior jobs to see tasks I could work on<br>
> to help out and get more acquainted with the marble source code. This one<br>
> looked pretty easy:<br>
> <a href="http://techbase.kde.org/Projects/Marble/GoMarble/JJ#Add_more_Plugin_Icons" target="_blank">http://techbase.kde.org/Projects/Marble/GoMarble/JJ#Add_more_Plugin_Icons</a><br>
> so I decided to start work on it. I still haven't finished it but I just<br>
> wanted to see if I was going on the right track and if you thought the<br>
> icon was appropriate. I'm basing this on the Wikipedia plugin which<br>
> already has an icon.<br>
><br>
> Best Regards,<br>
> Gabriel<br>
<br>
<br>
</div></div><font color="#888888">--<br>
10° 13' 41"O, 54° 24' 38"N<br>
</font><br>_______________________________________________<br>
Marble-devel mailing list<br>
<a href="mailto:Marble-devel@kde.org" target="_blank">Marble-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/marble-devel" target="_blank">https://mail.kde.org/mailman/listinfo/marble-devel</a><br>
<br></blockquote></div><br>