[Marble-devel] Review Request 126310: Fixing build error

[Christian Ehrlicher]

> On Jan. 3, 2016, 4:09 nachm., Christian Ehrlicher wrote:
> > Why not use the correct functions constFind/constBegin/constEnd instead?
> 
> Sandro Knauß wrote:
>     what should I do now? use const* functions or leave the patch unchanged?

I'm not a maintainer of marble - just looked over the reviews. But making an iterator const is a decision to make sure it is not changed in the loop. Changing it to a non-const iterator is imo a behaviour change and can be easily avoided by using the right functions.
I wonder why marble does not define 'QT_STRICT_ITERATORS' ...


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126310/#review90500
-----------------------------------------------------------


On Dez. 10, 2015, 9:51 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126310/
> -----------------------------------------------------------
> 
> (Updated Dez. 10, 2015, 9:51 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> error: conversion from 'QHash<int, QPair<double, double> >::iterator' to non-scalar type 'QHash<int, QPair<double, double> >::const_iterator' requested
> 
> 
> Diffs
> -----
> 
>   tools/constellations2kml/constellations2kml.cpp 5ab97ec3bd9a5f0e41a0e35a1c21039102d87cf2 
>   tools/mapreproject/OsmTileClusterRenderer.cpp 53c994cb404bfa10a53f47d85b97b4305d0501f4 
> 
> Diff: https://git.reviewboard.kde.org/r/126310/diff/
> 
> 
> Testing
> -------
> 
> before: doesn't build
> after: it builds :D
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20160103/59a105ae/attachment.html>