[Marble-devel] Review Request 123097: Added horizontal and vertical resize to GroundOverlay

Dávid Kolozsvári freedawson at gmail.com
Sun Mar 22 13:28:32 UTC 2015



> On March 22, 2015, 7:35 a.m., Torsten Rahn wrote:
> > src/plugins/render/annotate/GroundOverlayFrame.cpp, line 47
> > <https://git.reviewboard.kde.org/r/123097/diff/1/?file=356157#file356157line47>
> >
> >     Looks great except for the typo:
> >     
> >     northenBorder -> northernBorder

Thanks for the remark, fixed it :)


- Dávid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123097/#review77897
-----------------------------------------------------------


On March 22, 2015, 1:21 p.m., Dávid Kolozsvári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123097/
> -----------------------------------------------------------
> 
> (Updated March 22, 2015, 1:21 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The GroundOverlay was only resizable from its corners, this patch adds horizontal and vertical resize capability to it.
> Besides that, the corners are shown as nodes now, to let the user know that he can grab it.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.cpp cd5a334 
>   src/plugins/render/annotate/GroundOverlayFrame.h d8eee53 
>   src/plugins/render/annotate/GroundOverlayFrame.cpp d96bf4a 
>   src/plugins/render/annotate/SceneGraphicsItem.h cac5e4b 
> 
> Diff: https://git.reviewboard.kde.org/r/123097/diff/
> 
> 
> Testing
> -------
> 
> It was tested by me and works fine.
> 
> 
> Thanks,
> 
> Dávid Kolozsvári
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150322/fed9351d/attachment.html>


More information about the Marble-devel mailing list