[Marble-devel] Review Request 123837: gsoc: Solves coloring issue when loading OSM files

Torsten Rahn tackat at kde.org
Tue Jul 7 15:26:59 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123837/#review82183
-----------------------------------------------------------

Ship it!


Is this one still scheduled for submission? :-)

- Torsten Rahn


On Juni 14, 2015, 8:49 nachm., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123837/
> -----------------------------------------------------------
> 
> (Updated Juni 14, 2015, 8:49 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> When loading OSM files, features are assigned a hardcoded style ( corresponding to a tag ). That style was overwritten in the annotate plugin's loadAnnotationFile function.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.cpp 9284540 
> 
> Diff: https://git.reviewboard.kde.org/r/123837/diff/
> 
> 
> Testing
> -------
> 
> tested with the following file: http://textuploader.com/fwft
> -before the patch, the polygon is white (overwritten to default).
> -after the patch, the polygon is blue ( relation's water tag ).
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150707/0e2260d1/attachment.html>


More information about the Marble-devel mailing list