[Marble-devel] Review Request 117986: Bug 334285 - Equality operators for NetworkLink and NetworkLinkControl

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117986/#review57240
-----------------------------------------------------------



src/lib/marble/geodata/data/GeoDataNetworkLinkControl.cpp
<https://git.reviewboard.kde.org/r/117986/#comment39900>

    This can trigger, same for line 122, because the check for the nodeType() to be equal is not performed above. Just add it above like in the last review request:
    
    if ( d->m_abstractView->nodeType() != other.d->m_abstractView->nodeType() ) {
        return false;
    }
    


- Dennis Nienhüser


On May 4, 2014, 11:30 a.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117986/
> -----------------------------------------------------------
> 
> (Updated May 4, 2014, 11:30 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 334285
>     http://bugs.kde.org/show_bug.cgi?id=334285
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added operator== and operator!= to the classes GeoDataNetworkLink and GeoDataNetworkLinkControl.
> Extended TestEquality for new unit test methods for GeoDataNetworkLink and GeoDataNetworkLinkControl instances.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataNetworkLink.h c83040c 
>   src/lib/marble/geodata/data/GeoDataNetworkLink.cpp fddb21e 
>   src/lib/marble/geodata/data/GeoDataNetworkLinkControl.h a2e80a4 
>   src/lib/marble/geodata/data/GeoDataNetworkLinkControl.cpp a046b0d 
>   tests/TestEquality.cpp db625be 
> 
> Diff: https://git.reviewboard.kde.org/r/117986/diff/
> 
> 
> Testing
> -------
> 
> Tested with tests/TestEquality and works as expected.
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140504/1778d92b/attachment.html>