[Marble-devel] Review Request 114853: Use QPointer for dialog exec as identified by krazy

Commit Hook null at kde.org
Wed Jan 15 19:33:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114853/#review47468
-----------------------------------------------------------


This review has been submitted with commit bc70cb525b1eba87a9d2cb4fa5a9bd8892873ff8 by Dennis Nienhüser on behalf of Danny Rim to branch master.

- Commit Hook


On Jan. 15, 2014, 7:24 p.m., Danny Rim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114853/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2014, 7:24 p.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Use QPointer for dialog exec as identified by krazy
> 
> dlg renamed to dialog
> 
> GCI task http://www.google-melange.com/gci/task/view/google/gci2013/5855967858130944
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-kde/marble_part.cpp 497842a 
>   src/apps/marble-mobile/MobileMainWindow.cpp 751f4df 
>   src/lib/marble/BookmarkManagerDialog.cpp a67b099 
>   src/lib/marble/MapWizard.cpp 235f9df 
>   src/lib/marble/MarbleWidget.cpp ef0479e 
>   src/lib/marble/MarbleWidgetPopupMenu.cpp e527bdf 
>   src/lib/marble/TourWidget.cpp 12c42da 
>   src/lib/marble/routing/RoutingManager.cpp 013e392 
>   src/lib/marble/routing/RoutingWidget.cpp 4a83d34 
>   src/plugins/render/fileview/FileViewFloatItem.cpp ae6e1ba 
> 
> Diff: https://git.reviewboard.kde.org/r/114853/diff/
> 
> 
> Testing
> -------
> 
> Builds successfully, works
> 
> 
> Thanks,
> 
> Danny Rim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140115/4942d4f7/attachment-0001.html>


More information about the Marble-devel mailing list